[lldb] Use InlHostByteOrder in RegisterValue::SetValueFromData #169624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-lldb Author: Matej Košík (sedymrak) ChangesAn existing code can be further simplified. Full diff: https://github.com/llvm/llvm-project/pull/169624.diff 1 Files Affected:
diff --git a/lldb/source/Utility/RegisterValue.cpp b/lldb/source/Utility/RegisterValue.cpp
index c28c9e2d4d106..f555529d314e5 100644
--- a/lldb/source/Utility/RegisterValue.cpp
+++ b/lldb/source/Utility/RegisterValue.cpp
@@ -197,8 +197,7 @@ Status RegisterValue::SetValueFromData(const RegisterInfo ®_info,
else {
std::vector<uint8_t> native_endian_src(src_len, 0);
src.ExtractBytes(src_offset, src_len,
- llvm::sys::IsLittleEndianHost ? eByteOrderLittle
- : eByteOrderBig,
+ endian::InlHostByteOrder(),
native_endian_src.data());
llvm::APInt uint = llvm::APInt::getZero(src_len * 8);
llvm::LoadIntFromMemory(uint, native_endian_src.data(), src_len);
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Collaborator
|
Looks ok but please give this a (slightly) more descriptive title. "[lldb] Use InlHostByteOrder in RegisterValue::SetValueFromData" would be fine. |
sedymrak
changed the title
JDevlieghere
approved these changes
Nov 26, 2025
Member
|
LGTM. Please let us know if you need one of us to merge this on your behalf. |
Contributor
Author
Yes, if everything is in order with this pull-request, please merge this on my behalf. Thank you! |
tanji-dg
pushed a commit
to tanji-dg/llvm-project
that referenced
this pull request
Nov 27, 2025
…169624) An existing code can be further simplified. --------- Co-authored-by: Matej Košík <matej.kosik@codasip.com>
GeneraluseAI
pushed a commit
to GeneraluseAI/llvm-project
that referenced
this pull request
Nov 27, 2025
…169624) An existing code can be further simplified. --------- Co-authored-by: Matej Košík <matej.kosik@codasip.com>
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Dec 3, 2025
…169624) An existing code can be further simplified. --------- Co-authored-by: Matej Košík <matej.kosik@codasip.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An existing code can be further simplified.